squah-confluent commented on code in PR #24108:
URL: https://github.com/apache/kafka/pull/24108#discussion_r4519287849
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -8789,27 +8789,39 @@ private CoordinatorResult<HeartbeatResponseData,
CoordinatorRecord> classicGroup
String groupId = request.groupId();
String memberId = request.memberId();
String instanceId = request.groupInstanceId();
+ List<CoordinatorRecord> records = new ArrayList<>();
ConsumerGroupMember member = validateConsumerGroupMember(group,
memberId, instanceId);
throwIfMemberDoesNotUseClassicProtocol(member);
throwIfGenerationIdUnmatched(memberId, member.memberEpoch(),
request.generationId());
scheduleConsumerGroupSessionTimeout(groupId, memberId,
member.classicProtocolSessionTimeout().get());
+ // Update the target assignment if the group epoch is larger than the
target assignment epoch.
+ // The delta between the existing and the new target assignment is
persisted to the partition.
+ UpdateTargetAssignmentResult<Assignment> updateTargetAssignmentResult
= maybeUpdateTargetAssignment(
Review Comment:
Filed KAFKA-21458 for it. I'll keep both fixes in this PR so that it's
easier to cherry pick the metadata refresh fix to 4.0-4.3 if we want to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]