[
https://issues.apache.org/jira/browse/KAFKA-8501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858626#comment-16858626
]
ASF GitHub Bot commented on KAFKA-8501:
---------------------------------------
carlosduclos commented on pull request #6904: KAFKA-8501: Removing key and
value from exception message
URL: https://github.com/apache/kafka/pull/6904
Messages containing key and value were moved to the TRACE logging level,
however the exception is still adding the key and value.
This commits remove the key and value from StreamsException.
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
The content of the exception message is not tested anywhere, and I think it
would be really difficult to provide a reliable test to check for content
inside a string.
### Committer Checklist (excluded from commit message)
- [ X ] Verify design and implementation
- [ X ] Verify test coverage and CI build status
- [ X ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove key and value from exception message
> -------------------------------------------
>
> Key: KAFKA-8501
> URL: https://issues.apache.org/jira/browse/KAFKA-8501
> Project: Kafka
> Issue Type: Improvement
> Components: streams
> Reporter: Badai Aqrandista
> Priority: Major
> Labels: easy-fix, newbie
>
> KAFKA-7510 moves the WARN messages that contain key and value to TRACE level.
> But the exceptions still contain key and value. These are the two in
> RecordCollectorImpl:
>
> [https://github.com/apache/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java#L185-L196]
>
> [https://github.com/apache/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java#L243-L254]
>
> Can these be modified as well to remove key and value from the error message,
> which we don't know what log level it will be printed in?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
