chia7712 commented on code in PR #23837:
URL: https://github.com/apache/kafka/pull/23837#discussion_r4632304610


##########
docker/native/native-image-configs/reflect-config.json:
##########
@@ -900,26 +897,9 @@
   "methods":[{"name":"<init>","parameterTypes":[] }, 
{"name":"getLevel","parameterTypes":[] }, 
{"name":"getOtherProperties","parameterTypes":[] }, 
{"name":"setLevel","parameterTypes":["java.lang.String"] }, 
{"name":"setOtherProperties","parameterTypes":["java.lang.String","java.lang.Object"]
 }]
 },
 {
-  "name":"kafka.tools.DefaultMessageFormatter",
-  "methods":[{"name":"<init>","parameterTypes":[] }]
-},
-{
-  "name":"kafka.utils.Log4jController",
-  "queryAllPublicConstructors":true,
+  "name":"kafka.metrics.KafkaCSVMetricsReporter",

Review Comment:
   I had one concern that updating this file won't trigger the related tests. 
CI will still pass if someone deletes some items from this file 
unintentionally. However, that should be rare (I hope), and we can declare this 
file as a test input in `build.gradle` if it does happen.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to