[
https://issues.apache.org/jira/browse/KAFKA-8391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876307#comment-16876307
]
ASF GitHub Bot commented on KAFKA-8391:
---------------------------------------
rhauch commented on pull request #7019: KAFKA-8391: Improved the integration
tests to make them less flaky
URL: https://github.com/apache/kafka/pull/7019
Added the ability for the connector handles and task handles, which are used
by the monitorable source and sink connectors used to verify the functionality
of the Connect framework, to record the number of times the connector and tasks
have each been started, and to allow a test to obtain a `RestartLatch` that can
be used to block until the connectors and/or tasks have been restarted a
specified number of types.
Typically, a test will get the `ConnectorHandle` for a connector, and call
the `ConnectorHandle.expectedRestarts(int)` method with the expected number of
times that the connector and/or tasks will be restarted, and will hold onto the
resulting `RestartLatch`. The test will then change the connector (or otherwise
cause the connector to restart) one or more times as desired, and then call
`RestartLatch.await(long, TimeUnit)` to block the test up to a specified
duration for the connector and all tasks to be started the specified number of
times.
This commit also increases several of the maximum wait times used in other
integration tests. It doesn’t hurt to potentially wait longer, since most test
runs will not need to wait the maximum amount of time anyway. However, in the
rare cases that do need that extra time, waiting a bit more is fine if we can
reduce the flakiness and minimize test failures that happened to time out too
early.
Unit tests were added for the new `RestartLatch` and `StopAndStartCounter`
utility classes. This PR only affects the tests and does not affect any runtime
code or API.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Flaky Test RebalanceSourceConnectorsIntegrationTest#testDeleteConnector
> -----------------------------------------------------------------------
>
> Key: KAFKA-8391
> URL: https://issues.apache.org/jira/browse/KAFKA-8391
> Project: Kafka
> Issue Type: Bug
> Components: KafkaConnect
> Affects Versions: 2.3.0
> Reporter: Matthias J. Sax
> Assignee: Randall Hauch
> Priority: Critical
> Labels: flaky-test
> Fix For: 2.4.0
>
>
> [https://builds.apache.org/job/kafka-pr-jdk11-scala2.12/4747/testReport/junit/org.apache.kafka.connect.integration/RebalanceSourceConnectorsIntegrationTest/testDeleteConnector/]
> {quote}java.lang.AssertionError: Condition not met within timeout 30000.
> Connector tasks did not stop in time. at
> org.apache.kafka.test.TestUtils.waitForCondition(TestUtils.java:375) at
> org.apache.kafka.test.TestUtils.waitForCondition(TestUtils.java:352) at
> org.apache.kafka.connect.integration.RebalanceSourceConnectorsIntegrationTest.testDeleteConnector(RebalanceSourceConnectorsIntegrationTest.java:166){quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
