[ 
https://issues.apache.org/jira/browse/KAFKA-8653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16882576#comment-16882576
 ] 

ASF GitHub Bot commented on KAFKA-8653:
---------------------------------------

hachikuji commented on pull request #7072: KAFKA-8653; Default rebalance 
timeout to session timeout for JoinGroup v0
URL: https://github.com/apache/kafka/pull/7072
 
 
   The rebalance timeout was added to the JoinGroup protocol in version 1. 
Prior to 2.3, we handled version 0 JoinGroup requests by setting the rebalance 
timeout to be equal to the session timeout. We lost this logic when we 
converted the API to use the generated schema definition which uses the default 
value of -1. The impact of this is that the group rebalance timeout becomes 0, 
so rebalances finish immediately after we enter the PrepareRebalance state and 
kick out all old members. This causes consumer groups to enter an endless 
rebalance loop. This patch restores the old behavior.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Regression in JoinGroup v0 rebalance timeout handling
> -----------------------------------------------------
>
>                 Key: KAFKA-8653
>                 URL: https://issues.apache.org/jira/browse/KAFKA-8653
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 2.3.0
>            Reporter: Jason Gustafson
>            Assignee: Jason Gustafson
>            Priority: Blocker
>
> The rebalance timeout was added to the JoinGroup protocol in version 1. Prior 
> to 2.3, we handled version 0 JoinGroup requests by setting the rebalance 
> timeout to be equal to the session timeout. We lost this logic when we 
> converted the API to use the generated schema definition which uses the 
> default value of -1. The impact of this is that the group rebalance timeout 
> becomes 0, so rebalances finish immediately after we enter the 
> PrepareRebalance state and kick out all old members. This causes consumer 
> groups to enter an endless rebalance loop.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to