[ 
https://issues.apache.org/jira/browse/KAFKA-8782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904528#comment-16904528
 ] 

Ismael Juma edited comment on KAFKA-8782 at 8/10/19 10:37 PM:
--------------------------------------------------------------

Good catch [~apovzner]. Unfortunately this was not a source of test flakiness 
since `Metrics` had been created with enableExpiration=false. Still good to fix.


was (Author: ijuma):
Good catch [~apovzner]. Unfortunately this was not a source of test flakiness 
since `Metrics` had been created with 

enableExpiration=false.

> ReplicationQuotaManagerTest and ClientQuotaManagerTest should close Metrics 
> object
> ----------------------------------------------------------------------------------
>
>                 Key: KAFKA-8782
>                 URL: https://issues.apache.org/jira/browse/KAFKA-8782
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 2.2.1
>            Reporter: Anna Povzner
>            Assignee: Ismael Juma
>            Priority: Major
>              Labels: newbie
>             Fix For: 2.4.0
>
>
> ReplicationQuotaManagerTest and ClientQuotaManagerTest create Metrics objects 
> in several tests, but do not close() them in the end. It would be good to 
> cleanup resources in those tests, which also helps with reducing overall test 
> flakiness.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to