[ 
https://issues.apache.org/jira/browse/KAFKA-8841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16932604#comment-16932604
 ] 

ASF GitHub Bot commented on KAFKA-8841:
---------------------------------------

hachikuji commented on pull request #7324: KAFKA-8841: reduce overhead of 
ReplicaManager.updateFollowerFetchState
URL: https://github.com/apache/kafka/pull/7324
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Optimize Partition.maybeIncrementLeaderHW
> -----------------------------------------
>
>                 Key: KAFKA-8841
>                 URL: https://issues.apache.org/jira/browse/KAFKA-8841
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Jason Gustafson
>            Assignee: Lucas Bradstreet
>            Priority: Major
>
> We've observed a noticeable cost in `Partition.maybeIncrementLeaderHW` during 
> profiling. Basically just all the unnecessary collection copies and 
> iterations over the replica set. Since this is on the hot path for handling 
> follower fetches, we should probably put some effort into optimizing this. 
> A couple ideas:
>  # Don't do all those copies.
>  # Checking whether hw needs incrementing is not necessary unless an end 
> offset actually changed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to