[
https://issues.apache.org/jira/browse/KAFKA-8938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16937070#comment-16937070
]
ASF GitHub Bot commented on KAFKA-8938:
---------------------------------------
amcrn commented on pull request #7384: KAFKA-8938 - Connect - Improve
Allocations During Struct Validation
URL: https://github.com/apache/kafka/pull/7384
Summary: Struct value validation in Kafka Connect can be optimized
to avoid creating an Iterator when the expectedClasses list is of
size 1. This is a meaningful enhancement for high throughput
connectors.
This contribution is my original work and I license the work to the
project under the project's open source license.
Stack Trace from the Couchbase Kafka Connector:
```
* java.util.Collections.singletonIterator(Object)
* java.util.Collections$SingletonList.iterator()
* org.apache.kafka.connect.data.ConnectSchema.validateValue(String, Schema,
Object)
* org.apache.kafka.connect.data.Struct.put(Field, Object)
* org.apache.kafka.connect.data.Struct.put(String, Object)
*
com.couchbase.connect.kafka.handler.source.DefaultSchemaSourceHandler.buildValue(SourceHandlerParams,
CouchbaseSourceRecord$Builder)
```
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Connect - Improve Memory Allocations During Struct Validation
> -------------------------------------------------------------
>
> Key: KAFKA-8938
> URL: https://issues.apache.org/jira/browse/KAFKA-8938
> Project: Kafka
> Issue Type: Improvement
> Components: KafkaConnect
> Reporter: Auston McReynolds
> Priority: Minor
>
> Summary: Struct value validation in Kafka Connect can be optimized to avoid
> creating an Iterator when the expectedClasses list is of size 1. This is a
> meaningful enhancement for high throughput connectors.
> Stack Trace from the Couchbase Kafka Connector:
> * java.util.Collections.singletonIterator(Object)
> * java.util.Collections$SingletonList.iterator()
> * org.apache.kafka.connect.data.ConnectSchema.validateValue(String, Schema,
> Object)
> * org.apache.kafka.connect.data.Struct.put(Field, Object)
> * org.apache.kafka.connect.data.Struct.put(String, Object)
> *
> com.couchbase.connect.kafka.handler.source.DefaultSchemaSourceHandler.buildValue(SourceHandlerParams,
> CouchbaseSourceRecord$Builder)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
