[
https://issues.apache.org/jira/browse/KAFKA-8743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16947325#comment-16947325
]
ASF GitHub Bot commented on KAFKA-8743:
---------------------------------------
ableegoldman commented on pull request #7472: KAFKA-8743: Flaky Test
Repartition{WithMerge}OptimizingIntegrationTest
URL: https://github.com/apache/kafka/pull/7472
All four flavors of the repartition/optimization tests have been reported as
flaky and failed in one place or another:
`RepartitionOptimizingIntegrationTest.shouldSendCorrectRecords_OPTIMIZED`
`RepartitionOptimizingIntegrationTest.shouldSendCorrectRecords_NO_OPTIMIZATION`
`RepartitionWithMergeOptimizingIntegrationTest.shouldSendCorrectRecords_OPTIMIZED`
`RepartitionWithMergeOptimizingIntegrationTest.shouldSendCorrectRecords_NO_OPTIMIZATION`
They're pretty similar so it makes sense to knock them all out at once. This
PR does three things:
1. Switch to in-memory stores wherever possible
2. Name all operators and update the Topology accordingly (not really a
flaky test fix, but had to update the topology names anyway because of the IM
stores so figured might as well)
3. Double the timeout waiting to see all records. This is the "real" fix --
currently we use the default timeout (1 min), which is reasonable for most
integration tests that have a single subtopology, and records make only the one
roundtrip. These tests however require the records to go back and forth between
the brokers more than just once, due to the repartitioning, so it seems only
fair to give them a slightly higher timeout as records make the multiple
roundtrips.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Flaky Test
> RepartitionWithMergeOptimizingIntegrationTest#shouldSendCorrectRecords_OPTIMIZED
> -------------------------------------------------------------------------------------------
>
> Key: KAFKA-8743
> URL: https://issues.apache.org/jira/browse/KAFKA-8743
> Project: Kafka
> Issue Type: Bug
> Components: streams, unit tests
> Affects Versions: 2.4.0
> Reporter: Matthias J. Sax
> Assignee: Sophie Blee-Goldman
> Priority: Critical
> Labels: flaky-test
>
> [https://builds.apache.org/job/kafka-pr-jdk11-scala2.12/6662/testReport/junit/org.apache.kafka.streams.integration/RepartitionWithMergeOptimizingIntegrationTest/shouldSendCorrectRecords_OPTIMIZED/]
> {quote}java.lang.AssertionError: Condition not met within timeout 60000. Did
> not receive all [KeyValue(A, 6), KeyValue(B, 6), KeyValue(C, 6)] records from
> topic outputTopic_0 at
> org.apache.kafka.test.TestUtils.waitForCondition(TestUtils.java:376) at
> org.apache.kafka.test.TestUtils.waitForCondition(TestUtils.java:353) at
> org.apache.kafka.streams.integration.utils.IntegrationTestUtils.waitUntilFinalKeyValueRecordsReceived(IntegrationTestUtils.java:645)
> at
> org.apache.kafka.streams.integration.utils.IntegrationTestUtils.waitUntilFinalKeyValueRecordsReceived(IntegrationTestUtils.java:595)
> at
> org.apache.kafka.streams.integration.utils.IntegrationTestUtils.waitUntilFinalKeyValueRecordsReceived(IntegrationTestUtils.java:560)
> at
> org.apache.kafka.streams.integration.RepartitionWithMergeOptimizingIntegrationTest.runIntegrationTest(RepartitionWithMergeOptimizingIntegrationTest.java:164)
> at
> org.apache.kafka.streams.integration.RepartitionWithMergeOptimizingIntegrationTest.shouldSendCorrectRecords_OPTIMIZED(RepartitionWithMergeOptimizingIntegrationTest.java:105){quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
