[
https://issues.apache.org/jira/browse/KAFKA-9131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16965448#comment-16965448
]
ASF GitHub Bot commented on KAFKA-9131:
---------------------------------------
gleb-kom commented on pull request #7635: KAFKA-9131 remove dead code
responsible for handling timeout exceptio…
URL: https://github.com/apache/kafka/pull/7635
…ns in catch clause and move it to the callback
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> failed producer metadata updates result in the unrelated error message
> ----------------------------------------------------------------------
>
> Key: KAFKA-9131
> URL: https://issues.apache.org/jira/browse/KAFKA-9131
> Project: Kafka
> Issue Type: Bug
> Components: streams
> Affects Versions: 2.3.0
> Reporter: Gleb Komissarov
> Priority: Major
>
> {{Producer Metadata TimeoutException}} is processed as a generic
> RetriableException in RecordCollectorImpl.sendError. This results in an
> irrelevant error message.
> We were supposed to see this
> "Timeout exception caught when sending record to topic %s. " +
> "This might happen if the producer cannot send data to the Kafka cluster and
> thus, " +
> "its internal buffer fills up. " +
> "This can also happen if the broker is slow to respond, if the network
> connection to " +
> "the broker was interrupted, or if similar circumstances arise. " +
> "You can increase producer parameter `max.block.ms` to increase this
> timeout."
> but got this:
> "You can increase the producer configs `delivery.timeout.ms` and/or " +
> "`retries` to avoid this error. Note that `retries` is set to infinite by
> default."
> These params are not applicable to metadata updates.
> Technical details:
> (1) Lines 221 - 236 in
> kafka/streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java
> are dead code. They are never executed because {{producer.send}} never throws
> TimeoutException, but returns a failed future. You can see it in lines
> 948-955 in
> kafka/clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
> (2) The exception is then processed in a callback function in the method
> {{recordSendError}} on line 202. The DefaultProductionExceptionHandler is
> used.
> (3) in {{recordSendError}} in the same class the timeout exception is
> processed as RetriableException at lines 133-136. The error message is simply
> wrong because tweaking {{[delivery.timeout.ms|http://delivery.timeout.ms/]}}
> and {{retries}} has nothing to do with the issue in this case.
> Proposed solution:
> (1) Remove unreachable catch (final TimeoutException e) in
> RecordCollectorImpl.java as Producer does not throw ApiExceptions.
> (2) Move the aforementioned catch clause to recordSendError method.
> (3) Process TimeoutException separately from RetiriableException.
> (4) Implement a unit test to cover this corner case
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
