[
https://issues.apache.org/jira/browse/KAFKA-9088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16965677#comment-16965677
]
Pierangelo Di Pilato edited comment on KAFKA-9088 at 11/3/19 2:58 PM:
----------------------------------------------------------------------
Hi, I'm the author of the PR
[[7594|https://github.com/apache/kafka/pull/7594]|[https://github.com/apache/kafka/pull/7594]],
the strategy used in the PR was to merge `InternalMockProcessorContext` into
`MockInternalProcessorContext`.
As `InternalMocProcessorContext` extends `AbstractProcessorContext` I have
added `AbstractProcessorContext`, as superclass of `MockProcessorContext`, and
some behavior of the `InternalProcessorContext`, but [~cadonna] pointed out
that we can't change `MockProcessorContext` due to it falls into the public API
and from the discussion under the PR turns out that using `EasyMock` is better
than merging the two mocks.
So now, I'm trying to replace `InternalMockProcessorContext` and
`MockInternalProcessorContext` usages by `EasyMock` mocks.
Let me know If I'm missing something important.
was (Author: pierdipi):
Hi, I'm the author of the PR
[[7594|https://github.com/apache/kafka/pull/7594]|[https://github.com/apache/kafka/pull/7594]],
the strategy used in the PR was to merge `InternalMockProcessorContext` into
`MockInternalProcessorContext`.
As `InternalMocProcessorContext` extends `AbstractProcessorContext` I have
added `AbstractProcessorContext`, as superclass of `MockProcessorContext`, and
some behavior of the `InternalProcessorContext`, but [~cadonna] pointed out
that we can't change `MockProcessorContext` due to it falls into the public API
and from the discussion under the PR turns out that using `EasyMock` is better
than merging the two mocks.
So now, I'm trying to replace `InternalMockProcessorContext` and
`MockInternalProcessorContext` usages by `EasyMock` mocks.
let me know If I'm missing something important.
> Consolidate InternalMockProcessorContext and MockInternalProcessorContext
> -------------------------------------------------------------------------
>
> Key: KAFKA-9088
> URL: https://issues.apache.org/jira/browse/KAFKA-9088
> Project: Kafka
> Issue Type: Improvement
> Components: streams, unit tests
> Reporter: Bruno Cadonna
> Priority: Minor
> Labels: newbie
>
> Currently, we have two mocks for the {{InternalProcessorContext}}. The goal
> of this ticket is to merge both into one mock or replace it with an
> {{EasyMock}} mock.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
