[
https://issues.apache.org/jira/browse/KAFKA-9200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976178#comment-16976178
]
ASF GitHub Bot commented on KAFKA-9200:
---------------------------------------
lbradstreet commented on pull request #7704: KAFKA-9200: ListOffsetRequest
missing error response for v5
URL: https://github.com/apache/kafka/pull/7704
ListOffsetResponse getErrorResponse is missing a a case for version 5, added
in 2.3.0.
It seems we have missing test coverage for checking error responses. I'm
creating the PR early in case we want to merge this early before 2.4.0 is
released.
```
java.lang.IllegalArgumentException: Version 5 is not valid. Valid versions
for ListOffsetRequest are 0 to 5
at
org.apache.kafka.common.requests.ListOffsetRequest.getErrorResponse(ListOffsetRequest.java:282)
at
kafka.server.KafkaApis.sendErrorOrCloseConnection(KafkaApis.scala:3062)
at
kafka.server.KafkaApis.sendErrorResponseMaybeThrottle(KafkaApis.scala:3045)
at kafka.server.KafkaApis.handleError(KafkaApis.scala:3027)
at kafka.server.KafkaApis.handle(KafkaApis.scala:209)
at
kafka.server.KafkaRequestHandler.run(KafkaRequestHandler.scala:78)
at java.lang.Thread.run(Thread.java:748)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ListOffsetRequest missing error response for v5
> -----------------------------------------------
>
> Key: KAFKA-9200
> URL: https://issues.apache.org/jira/browse/KAFKA-9200
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 2.3.0
> Reporter: Lucas Bradstreet
> Assignee: Lucas Bradstreet
> Priority: Minor
>
> It seems ListOffsetResponse getErrorResponse is missing a a case for version
> 5. I'd have hoped that this kind of case would be picked up by KafkaApisTest.
> {noformat}
> java.lang.IllegalArgumentException: Version 5 is not valid. Valid versions
> for ListOffsetRequest are 0 to 5
>
>
>
> at
> org.apache.kafka.common.requests.ListOffsetRequest.getErrorResponse(ListOffsetRequest.java:282)
>
>
>
>
> at
> kafka.server.KafkaApis.sendErrorOrCloseConnection(KafkaApis.scala:3062)
>
>
>
>
> at
> kafka.server.KafkaApis.sendErrorResponseMaybeThrottle(KafkaApis.scala:3045)
>
>
>
>
> at kafka.server.KafkaApis.handleError(KafkaApis.scala:3027)
>
>
>
>
> at kafka.server.KafkaApis.handle(KafkaApis.scala:209)
>
>
>
>
> at kafka.server.KafkaRequestHandler.run(KafkaRequestHandler.scala:78)
>
>
>
>
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
