[ 
https://issues.apache.org/jira/browse/KAFKA-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16990133#comment-16990133
 ] 

ASF GitHub Bot commented on KAFKA-7588:
---------------------------------------

omkreddy commented on pull request #7794: KAFKA-7588: Pass custom configs to 
the ChannelBuilder implementations
URL: https://github.com/apache/kafka/pull/7794
 
 
   
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Rationalize configurations passed to pluggable APIs
> ---------------------------------------------------
>
>                 Key: KAFKA-7588
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7588
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Mickael Maison
>            Assignee: Mickael Maison
>            Priority: Major
>
> There are a lot of extensions points both on the client and server sides. 
> Most of these pluggable APIs are configurable but the configurations they 
> receive are not the same.
> For example, Serializers, Deserializers, Partitioners, Assignors, 
> QuotaCallbacks are passed config.originals(). On the other hand LoginModules, 
> PrincipalBuilders and AuthenticationCallbackHandlers are passed 
> config.values().
> In practice, having access to originals() is nice as it allows to use custom 
> configurations by simply adding it to the client/server configuration.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to