[ 
https://issues.apache.org/jira/browse/KAFKA-9332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17002816#comment-17002816
 ] 

ASF GitHub Bot commented on KAFKA-9332:
---------------------------------------

sasukerui commented on pull request #7869: KAFKA-9332 change how to get 
joinGroupTimeoutMs
URL: https://github.com/apache/kafka/pull/7869
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> change how to get joinGroupTimeoutMs
> ------------------------------------
>
>                 Key: KAFKA-9332
>                 URL: https://issues.apache.org/jira/browse/KAFKA-9332
>             Project: Kafka
>          Issue Type: Improvement
>          Components: consumer
>    Affects Versions: 2.0.0, 2.2.0
>            Reporter: qianrui
>            Priority: Major
>             Fix For: 2.0.0
>
>
> in the AbstractCoordinator class
> int joinGroupTimeoutMs = Math.max(rebalanceTimeoutMs, rebalanceTimeoutMs + 
> 5000);
> l think  rebalanceTimeoutMs + 5000 is always greater than 
> rebalanceTimeoutMs,It would be better to write  joinGroupTimeoutMs = 
> rebalanceTimeoutMs + 5000。



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to