[
https://issues.apache.org/jira/browse/KAFKA-9404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013805#comment-17013805
]
ASF GitHub Bot commented on KAFKA-9404:
---------------------------------------
belugabehr commented on pull request #7936: KAFKA-9404: Use ArrayList instead
of LinkedList in Sensor Class
URL: https://github.com/apache/kafka/pull/7936
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use ArrayList instead of LinkedList in Sensor Class
> ---------------------------------------------------
>
> Key: KAFKA-9404
> URL: https://issues.apache.org/jira/browse/KAFKA-9404
> Project: Kafka
> Issue Type: Improvement
> Reporter: David Mollitor
> Priority: Trivial
>
> Since this collection is going to be bulk-built once and not modified, better
> to use an {{ArrayList}} since its memory requirements are smaller and it is
> much faster here... just instantiate the internal array once and fill it...
> as opposed to {{LinkedList}} that must build the nodes for each item
> inserted. {{ArrayList}} is also faster for iteration.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
