[
https://issues.apache.org/jira/browse/KAFKA-9358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17016325#comment-17016325
]
ASF GitHub Bot commented on KAFKA-9358:
---------------------------------------
mumrah commented on pull request #7968: KAFKA-9358 Explicitly unregister
brokers and controller from ZK
URL: https://github.com/apache/kafka/pull/7968
Instead of closing the zkClient immediately after controller shutdown, the
controller now resigns on shutdown rather than relying on the zkClient shutdown
to implicitly do so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Explicitly resign controller leadership and broker znode
> --------------------------------------------------------
>
> Key: KAFKA-9358
> URL: https://issues.apache.org/jira/browse/KAFKA-9358
> Project: Kafka
> Issue Type: Improvement
> Components: controller, core
> Reporter: Lucas Bradstreet
> Assignee: Lucas Bradstreet
> Priority: Major
>
> When shutting down the controller the broker shuts down the controller and
> then closes the zookeeper connection. Closing the zookeeper connection
> results in ephemeral nodes being removed. It is currently critical that the
> zkClient is closed after the controller is shutdown, otherwise a controller
> election will not occur if the broker being shutdown is currently the
> controller.
> We should consider resigning leadership explicitly in the controller rather
> than relying on the zookeeper client being closed. This would ensure that any
> changes in shutdown order cannot lead to periods where a broker's controller
> component is stopped while also maintaining leadership until the zkClient is
> closed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
