[ 
https://issues.apache.org/jira/browse/KAFKA-9490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029408#comment-17029408
 ] 

ASF GitHub Bot commented on KAFKA-9490:
---------------------------------------

mjsax commented on pull request #8028: KAFKA-9490: Fix generics for Grouped
URL: https://github.com/apache/kafka/pull/8028
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Some factory methods in Grouped are missing generic parameters
> --------------------------------------------------------------
>
>                 Key: KAFKA-9490
>                 URL: https://issues.apache.org/jira/browse/KAFKA-9490
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>    Affects Versions: 2.4.0
>            Reporter: Dariusz Kordonski
>            Assignee: Matthias J. Sax
>            Priority: Minor
>             Fix For: 2.5.0
>
>
> The following methods in {{Grouped}} class seem to be missing generic 
> parameters {{<K,V>}} in the declared return type:
> {code:java}
> public static <K> Grouped keySerde(final Serde<K> keySerde) { return new      
>  Grouped<>(null, keySerde, null); 
> }
> public static <V> Grouped valueSerde(final Serde<V> valueSerde) { return new 
> Grouped<>(null, null, valueSerde); 
> } {code}
> I think it both cases it should be:
> {code:java}
> public static <K,V> Grouped<K,V> ...() {code}
> This causes "unchecked call" compiler warnings when called by clients.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to