[
https://issues.apache.org/jira/browse/KAFKA-7869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058269#comment-17058269
]
John Roesler commented on KAFKA-7869:
-------------------------------------
Hey [~dongjin] ,
The last comments on the PR seem sort of existential... Do you think we should
still proceed with this work, or just close the ticket (with documented
reasoning)?
> Refactor RocksDBConfigSetter API to separate DBOptions and CFOptions
> --------------------------------------------------------------------
>
> Key: KAFKA-7869
> URL: https://issues.apache.org/jira/browse/KAFKA-7869
> Project: Kafka
> Issue Type: Improvement
> Components: streams
> Reporter: Guozhang Wang
> Assignee: Dongjin Lee
> Priority: Major
> Labels: needs-kip, newbie
>
> Current RocksDBConfigSetter has the following API:
> {code}
> void setConfig(final String storeName, final Options options, final
> Map<String, Object> configs);
> {code}
> Where `Options` contains configurations for both db-level and cf-level of
> RocksDB.
> As we move on to have multiple CFs following KIP-258, it's better to refactor
> it into
> {code}
> void setConfig(final String storeName, final DBOptions dbOptions, final
> ColumnFamilyOptions cfOptions, final Map<String, Object> configs);
> {code}
> And then inside the internal implementation, if only the default CF is used,
> we can still use the other constructor of `Options` that takes both a
> DBOptions and CFOptions object as parameters.
> This should be started only after KIP-258 is finished.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
