[
https://issues.apache.org/jira/browse/KAFKA-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17067005#comment-17067005
]
ASF GitHub Bot commented on KAFKA-8319:
---------------------------------------
cadonna commented on pull request #8352: KAFKA-8319: Make KafkaStreamsTest a
non-integration test class
URL: https://github.com/apache/kafka/pull/8352
Previous KafkaStreamsTest takes 2min20s on my local laptop, because lots of
its integration test which is producing / consuming records, and checking state
directory file system takes lots of time. On the other hand, these tests should
be well simplified with mocks.
This test reduces the test from a clumsy integration test class into a unit
tests with mocks of its internal modules. And some other test functions should
not be in KafkaStreamsTest actually and have been moved to other modular test
classes. Now it takes 2s.
Also it helps removing the potential flakiness of the following (some of
them are claimed resolved only because we have not seen them recently, but
after looking at the test code I can verify they are still flaky):
* KAFKA-5818 (the original JIRA ticket indeed exposed a real issue that has
been fixed, but the test itself remains flaky)
* KAFKA-6215
* KAFKA-7921
* KAFKA-7990
* KAFKA-8319
* KAFKA-8427
Reviewers: Bill Bejeck <b...@confluent.io>, John Roesler
<j...@confluent.io>, Bruno Cadonna <br...@confluent.io>
This commit was cherry-picked from trunk and adapted.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Flaky Test KafkaStreamsTest.statefulTopologyShouldCreateStateDirectory
> ----------------------------------------------------------------------
>
> Key: KAFKA-8319
> URL: https://issues.apache.org/jira/browse/KAFKA-8319
> Project: Kafka
> Issue Type: Bug
> Components: streams
> Reporter: Bill Bejeck
> Assignee: Guozhang Wang
> Priority: Major
> Labels: flaky-test
> Fix For: 2.4.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
