[
https://issues.apache.org/jira/browse/KAFKA-9767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17067255#comment-17067255
]
ASF GitHub Bot commented on KAFKA-9767:
---------------------------------------
C0urante commented on pull request #8357: KAFKA-9767: Add logging to basic auth
rest extension
URL: https://github.com/apache/kafka/pull/8357
[Jira](https://issues.apache.org/jira/browse/KAFKA-9767)
The changes here are strictly targeted towards improving logging for the
basic auth rest extension. However, in several sections, some refactoring is
also performed in order to reduce nesting especially with the `else` halves of
`if`/`else` statements.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Basic auth extension should have logging
> ----------------------------------------
>
> Key: KAFKA-9767
> URL: https://issues.apache.org/jira/browse/KAFKA-9767
> Project: Kafka
> Issue Type: Improvement
> Components: KafkaConnect
> Reporter: Chris Egerton
> Assignee: Chris Egerton
> Priority: Minor
>
> The three classes for Connect's basic auth REST extension are pretty light on
> logging, which makes debugging issues and interplay between the REST
> extension and whatever JAAS login module the user may have configured
> difficult. We should add some more extensive logging to these classes, while
> taking care to prevent log spam in the case of repeated unauthenticated
> requests or leaking of sensitive information.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
