[ https://issues.apache.org/jira/browse/KAFKA-3720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072225#comment-17072225 ]
ASF GitHub Bot commented on KAFKA-3720: --------------------------------------- soenkeliebau commented on pull request #8399: KAFKA-3720: Change TimeoutException to BufferExhaustedException when no memory can be allocated for a record within max.block.ms URL: https://github.com/apache/kafka/pull/8399 Change TimeoutException to BufferExhaustedException when no memory can be allocated for a record within max.block.ms Refactored BufferExhaustedException to be a subclass of TimeoutException so existing code that catches TimeoutExceptions keeps working. Added handling to count these Exceptions in the metric "buffer-exhausted-records". Test Strategy There were existing test cases to check this behavior, which I refactored. I then added an extra case to check whether the expected Exception is actually thrown, which was not covered by current tests. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove BufferExhaustException from doSend() in KafkaProducer > ------------------------------------------------------------ > > Key: KAFKA-3720 > URL: https://issues.apache.org/jira/browse/KAFKA-3720 > Project: Kafka > Issue Type: Bug > Reporter: Mayuresh Gharat > Assignee: Mayuresh Gharat > Priority: Major > > KafkaProducer no longer throws BufferExhaustException. We should remove it > from the catch clause. -- This message was sent by Atlassian Jira (v8.3.4#803005)