[
https://issues.apache.org/jira/browse/KAFKA-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17075562#comment-17075562
]
ASF GitHub Bot commented on KAFKA-9761:
---------------------------------------
MikeSchlosser16 commented on pull request #8427: [KAFKA-9761] Use Admin Client
default timeout instead of using 5sec timeout default
URL: https://github.com/apache/kafka/pull/8427
Corresponds to: https://issues.apache.org/jira/browse/KAFKA-9761
Changes the `timeout` flag in the `kafka-consumer-groups` tool to not
default to 5000ms. It now uses the Admin Client default(30s currently) by not
setting `options.timeoutMs` unless the timeout flag is specified, in which case
it ends up using `(min(30s, timeout flag))` in the `AdminClientRunnable` method
`sendEligibleCalls`.
Unit tests are provided that work with the default value and the old default
5000ms. There were already tests for an unreasonably short timeout.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> kafka-consumer-groups tool overrides admin client defaults with a short 5 s
> timeout
> -----------------------------------------------------------------------------------
>
> Key: KAFKA-9761
> URL: https://issues.apache.org/jira/browse/KAFKA-9761
> Project: Kafka
> Issue Type: Bug
> Reporter: Colin McCabe
> Assignee: Colin McCabe
> Priority: Major
> Labels: newbie
>
> kafka-consumer-groups tool overrides admin client defaults with a short 5 s
> timeout. It should leave the default timeouts alone unless --timeout is
> specified
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
