[
https://issues.apache.org/jira/browse/KAFKA-8955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17087726#comment-17087726
]
ASF GitHub Bot commented on KAFKA-8955:
---------------------------------------
ijuma commented on a change in pull request #8417:
URL: https://github.com/apache/kafka/pull/8417#discussion_r411379678
##########
File path:
clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java
##########
@@ -57,6 +59,10 @@ public ByteBuffer serialize(ApiKeys apiKey, short version,
int correlationId) {
return Collections.singletonMap(error, 1);
}
+ protected Map<Errors, Integer> errorCounts(Stream<Errors> errors) {
+ return errors.collect(Collectors.groupingBy(e -> e,
Collectors.summingInt(e -> 1)));
+ }
+
protected Map<Errors, Integer> errorCounts(Collection<Errors> errors) {
Map<Errors, Integer> errorCounts = new HashMap<>();
for (Errors error : errors)
Review comment:
We can probably update `updateErrorsCounts` to use `getOrDefault` (I
can't comment on the relevant line directly).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add an AbstractResponse#errorCounts method that takes a stream or iterable
> --------------------------------------------------------------------------
>
> Key: KAFKA-8955
> URL: https://issues.apache.org/jira/browse/KAFKA-8955
> Project: Kafka
> Issue Type: Improvement
> Reporter: Colin McCabe
> Assignee: Tom Bentley
> Priority: Minor
>
> We should have an AbstractResponse#errorCounts method that takes a stream or
> iterable. This would allow us to avoid copying data in many cases.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
