apovzner commented on issue #8509: URL: https://github.com/apache/kafka/pull/8509#issuecomment-616658368
@dajac I did initially add a unit test to `KafkaApisTest` for UpdateMetadataRequest. However, since `KafkaApisTest` mocks pretty much every other component (like replica manager, etc), the only thing it would test is the fact that passing newer broker epoch would know throw `IllegalStateException`. Basically, it does not add any more coverage in addition to `BrokerEpochIntegrationTest` which also tests more of a code path. Given this info, you still think we should add it? Or perhaps there are more reasons I missed? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
