lbradstreet commented on a change in pull request #8518:
URL: https://github.com/apache/kafka/pull/8518#discussion_r411544719



##########
File path: tests/kafkatest/tests/core/downgrade_test.py
##########
@@ -67,11 +67,18 @@ def setup_services(self, kafka_version, compression_types, 
security_protocol):
                              version=kafka_version)
         self.producer.start()
 
+        static_membership = kafka_version == DEV_BRANCH or kafka_version >= 
LATEST_2_3

Review comment:
       Good question, without it the verifiable consumer fails with:
   ```
   usage: verifiable-consumer [-h]                                              
                                                                                
                                                                                
                
                              --broker-list HOST1:PORT1[,HOST2:PORT2[...]]      
                                                                                
                                                                                
                
                              --topic TOPIC --group-id GROUP_ID                 
                                                                                
                                                                                
                
                              --group-instance-id GROUP_INSTANCE_ID             
                                                                                
                                                                                
                
                              [--max-messages MAX-MESSAGES]                     
                                                                                
                                                                                
                
                              [--session-timeout TIMEOUT_MS] [--verbose]        
                                                                                
                                                                                
                
                              [--enable-autocommit]                             
                                                                                
                                                                                
                
                              [--reset-policy RESETPOLICY]                      
                                                                                
                                                                                
                
                              [--assignment-strategy ASSIGNMENTSTRATEGY]        
                                                                                
                                                                                
                
                              [--consumer.config CONFIG_FILE]                   
                                                                                
                                                                                
                
   verifiable-consumer: error: argument --group-instance-id is required         
                                                                                
                                                                                
                
   ```
   
   I assumed that this check was added for a reason, however maybe it's being 
to strict?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to