[GitHub] [kafka] abbccdda commented on a change in pull request #8486: KAFKA-9840: Skip End Offset validation when the leader epoch is not reliable

[GitBox]

abbccdda commented on a change in pull request #8486:
URL: https://github.com/apache/kafka/pull/8486#discussion_r412633349



##########
File path: clients/src/test/java/org/apache/kafka/clients/MetadataTest.java
##########
@@ -199,19 +200,21 @@ public void 
testIgnoreLeaderEpochInOlderMetadataResponse() {
             MetadataResponse response = new MetadataResponse(struct, version);
             assertFalse(response.hasReliableLeaderEpochs());
             metadata.updateWithCurrentRequestVersion(response, false, 100);
+            assertFalse(metadata.hasReliableLeaderEpochs());

Review comment:
       Added test coverage L203 and L214, other changes are just side cleanups 
and signature refactoring in this file.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org