abbccdda commented on a change in pull request #8495:
URL: https://github.com/apache/kafka/pull/8495#discussion_r413199411
##########
File path: tests/kafkatest/tests/core/downgrade_test.py
##########
@@ -26,10 +27,12 @@
from kafkatest.version import LATEST_0_9, LATEST_0_10, LATEST_0_10_0,
LATEST_0_10_1, LATEST_0_10_2, LATEST_0_11_0, LATEST_1_0, LATEST_1_1,
LATEST_2_0, LATEST_2_1, LATEST_2_2, LATEST_2_3, V_0_9_0_0, V_0_11_0_0,
DEV_BRANCH, KafkaVersion
class TestDowngrade(EndToEndTest):
+ PARTITIONS = 3
+ REPLICATION_FACTOR = 3
TOPIC_CONFIG = {
- "partitions": 3,
- "replication-factor": 3,
+ "partitions": PARTITIONS,
Review comment:
Is this necessary to be defined as constants?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
