cmccabe commented on a change in pull request #8527:
URL: https://github.com/apache/kafka/pull/8527#discussion_r413719892
##########
File path:
core/src/test/scala/unit/kafka/admin/ReassignPartitionsCommandArgsTest.scala
##########
@@ -255,7 +225,7 @@ class ReassignPartitionsCommandArgsTest {
@Test
def shouldNotAllowBrokersListWithVerifyOption(): Unit = {
val args = Array(
- "--zookeeper", "localhost:1234",
+ "--bootstrap-server", "localhost:1234",
Review comment:
This is a good change since the test is not specifically testing the
legacy mode (so it should use the new mode) Keep this one
##########
File path:
core/src/test/scala/unit/kafka/admin/ReassignPartitionsCommandArgsTest.scala
##########
@@ -275,7 +245,7 @@ class ReassignPartitionsCommandArgsTest {
@Test
def shouldNotAllowTopicsOptionWithVerify(): Unit = {
val args = Array(
- "--zookeeper", "localhost:1234",
+ "--bootstrap-server", "localhost:1234",
Review comment:
keep this change
##########
File path:
core/src/test/scala/unit/kafka/admin/ReassignPartitionsCommandArgsTest.scala
##########
@@ -265,7 +235,7 @@ class ReassignPartitionsCommandArgsTest {
@Test
def shouldNotAllowThrottleWithVerifyOption(): Unit = {
val args = Array(
- "--zookeeper", "localhost:1234",
+ "--bootstrap-server", "localhost:1234",
Review comment:
keep this change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
