vvcephei commented on a change in pull request #8541:
URL: https://github.com/apache/kafka/pull/8541#discussion_r414662116
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfiguration.java
##########
@@ -41,8 +42,8 @@
import static
org.apache.kafka.streams.processor.internals.assignment.StreamsAssignmentProtocolVersions.LATEST_SUPPORTED_VERSION;
public final class AssignorConfiguration {
- public static final String HIGH_AVAILABILITY_ENABLED_CONFIG =
"internal.high.availability.enabled";
- private final boolean highAvailabilityEnabled;
+ public static final String INTERNAL_TASK_ASSIGNOR_CLASS =
"internal.task.assignor.class";
Review comment:
Ok, I moved it to
`org.apache.kafka.streams.StreamsConfig.InternalConfig#INTERNAL_TASK_ASSIGNOR_CLASS`.
I made an ad-hoc decision not to add the underscores, though, because this
config is different than the other internal configs. I added comments to
InternalConfig to explain the difference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
