[GitHub] [kafka] junrao commented on a change in pull request #8524: KAFKA-9866: Avoid election for topics where preferred leader is not in ISR

[GitBox]

junrao commented on a change in pull request #8524:
URL: https://github.com/apache/kafka/pull/8524#discussion_r414740034



##########
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##########
@@ -1068,12 +1068,23 @@ class KafkaController(val config: KafkaConfig,
         val candidatePartitions = topicsNotInPreferredReplica.keys.filter(tp 
=> controllerContext.isReplicaOnline(leaderBroker, tp) &&
           controllerContext.partitionsBeingReassigned.isEmpty &&
           !topicDeletionManager.isTopicQueuedUpForDeletion(tp.topic) &&
-          controllerContext.allTopics.contains(tp.topic))
+          controllerContext.allTopics.contains(tp.topic) &&
+          isPreferredLeaderInSync(tp)
+       )
         onReplicaElection(candidatePartitions.toSet, ElectionType.PREFERRED, 
AutoTriggered)
       }
     }
   }
 
+  private def isPreferredLeaderInSync(tp: TopicPartition): Boolean = {

Review comment:
       Perhaps a more accurate name is canPreferredReplicaBeLeader()?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org