vvcephei commented on a change in pull request #8540:
URL: https://github.com/apache/kafka/pull/8540#discussion_r414916950
##########
File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java
##########
@@ -327,15 +331,15 @@ private void prepareStreamThread(final StreamThread
thread, final boolean termin
@Test
public void testShouldTransitToNotRunningIfCloseRightAfterCreated() {
- final KafkaStreams streams = new KafkaStreams(new
StreamsBuilder().build(), props, supplier, time);
+ final KafkaStreams streams = new
KafkaStreams(getBuilderWithSource().build(), props, supplier, time);
Review comment:
I think the suggestion was more along the lines of _not_ throwing an
exception while building an empty topology.
I'm not sure. It seems kind of nice to find out right away that your program
will do absolutely nothing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
