ableegoldman commented on a change in pull request #8548:
URL: https://github.com/apache/kafka/pull/8548#discussion_r415991034



##########
File path: 
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##########
@@ -1231,13 +1235,13 @@ public void handle(OffsetCommitResponse commitResponse, 
RequestFuture<Void> futu
 
                             // only need to reset generation and re-join group 
if generation has not changed;
                             // otherwise only raise rebalance-in-progress error

Review comment:
       Should we update the comment here (and on line 1205)?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to