ableegoldman commented on a change in pull request #8541:
URL: https://github.com/apache/kafka/pull/8541#discussion_r416178865
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/LagFetchIntegrationTest.java
##########
@@ -147,6 +149,9 @@ private void shouldFetchLagsDuringRebalancing(final String
optimization) throws
// create stream threads
for (int i = 0; i < 2; i++) {
final Properties props = (Properties) streamsConfiguration.clone();
+ // this test relies on the second instance getting the standby, so
we specify
+ // an assignor with this contract.
+
props.put(StreamsConfig.InternalConfig.INTERNAL_TASK_ASSIGNOR_CLASS,
PriorTaskAssignor.class.getName());
Review comment:
It would be nice to take advantage of the now-pluggable assignor and
write a test utility assignor that allows you to specify the assignment you
want and the validate the inputs that you get. Obviously beyond the scope of
the current PR, just a thought I had. Using the PriorTaskAssignor seems like
the next best thing so 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
