vvcephei commented on a change in pull request #8564:
URL: https://github.com/apache/kafka/pull/8564#discussion_r416232363
##########
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/TimestampedWindowStoreBuilder.java
##########
@@ -56,6 +59,11 @@ public TimestampedWindowStoreBuilder(final
WindowBytesStoreSupplier storeSupplie
store = new InMemoryTimestampedWindowStoreMarker(store);
}
}
+ if (storeSupplier.retainDuplicates()) {
Review comment:
```suggestion
if (storeSupplier.retainDuplicates() && enableCaching) {
```
Should we only log if we're changing the configured caching? (Also applies
below)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
