guozhangwang commented on a change in pull request #8578:
URL: https://github.com/apache/kafka/pull/8578#discussion_r417558079
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java
##########
@@ -145,12 +162,12 @@ public static void cleanStateBeforeTest(final
EmbeddedKafkaCluster cluster, fina
}
}
- public static void cleanStateAfterTest(final EmbeddedKafkaCluster cluster,
final KafkaStreams driver) {
- driver.cleanUp();
+ public static void quietlyCleanStateAfterTest(final EmbeddedKafkaCluster
cluster, final KafkaStreams driver) {
try {
+ driver.cleanUp();
cluster.deleteAllTopicsAndWait(DEFAULT_TIMEOUT);
- } catch (final InterruptedException e) {
- throw new RuntimeException(e);
+ } catch (final RuntimeException | InterruptedException e) {
+ LOG.warn("Ignoring failure to clean test state", e);
}
Review comment:
Sounds good. I think this is convincing :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
