[
https://issues.apache.org/jira/browse/KAFKA-9925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095934#comment-17095934
]
John Roesler commented on KAFKA-9925:
-------------------------------------
Just saw this conversation. Thanks for the idea, [~guozhang] . I guess it's
moot now, since I've just merged the PR ;)
I agree we should consider that separately, since we need to backport the fix.
Plus, to replace the run time vs build time problem, we'd have to _remove_
`build()`, not just _deprecate_ it, so I think even after KIP-591, we'll have
to support this code path for a while.
Anyway, I'm resolving this ticket, since the fix is merged to trunk, 2.5, and
2.4. Thanks for the report and review, [~nikuis] ! And sorry again for the
trouble.
> Non-key KTable Joining may result in duplicate schema name in confluence
> schema registry
> ----------------------------------------------------------------------------------------
>
> Key: KAFKA-9925
> URL: https://issues.apache.org/jira/browse/KAFKA-9925
> Project: Kafka
> Issue Type: Bug
> Components: streams
> Affects Versions: 2.4.1
> Reporter: Kin Siu
> Assignee: John Roesler
> Priority: Major
>
> The second half of issue Andy Bryant reported in KAFKA-9390 looks like still
> exist.
> When testing non-key join method without passing in "Named", I noticed that
> there are schema subjects registered in confluent schema registry without
> consumer group Id still,
> e.g.
> {noformat}
> "KTABLE-FK-JOIN-SUBSCRIPTION-REGISTRATION-0000000005-topic-pk-key",
> "KTABLE-FK-JOIN-SUBSCRIPTION-REGISTRATION-0000000005-topic-fk-key",
> "KTABLE-FK-JOIN-SUBSCRIPTION-REGISTRATION-0000000005-topic-vh-value",
> "KTABLE-FK-JOIN-SUBSCRIPTION-REGISTRATION-0000000025-topic-pk-key",
> "KTABLE-FK-JOIN-SUBSCRIPTION-REGISTRATION-0000000025-topic-fk-key",
> "KTABLE-FK-JOIN-SUBSCRIPTION-REGISTRATION-0000000025-topic-vh-value"
> {noformat}
> Code in KTableImpl which constructed above naming :
> https://github.com/apache/kafka/blob/2.4.1/streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java#L959
> When we have multiple topologies using foreignKey join and registered to same
> schema registry, we can have a name clash, and fail to register schema.
> In order to clean up these schema subjects, we will need to know the internal
> naming of a consumer group's topology, which is not straightforward and error
> prone.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
