ijuma commented on a change in pull request #8151:
URL: https://github.com/apache/kafka/pull/8151#discussion_r418039254
##########
File path: core/src/test/scala/unit/kafka/server/AdvertiseBrokerTest.scala
##########
@@ -77,17 +80,17 @@ class AdvertiseBrokerTest extends ZooKeeperTestHarness {
servers += TestUtils.createServer(KafkaConfig.fromProps(props))
val brokerInfo = zkClient.getBroker(brokerId).get
- assertEquals(1, brokerInfo.endPoints.size)
+ assertEquals(2, brokerInfo.endPoints.size)
val endpoint = brokerInfo.endPoints.head
assertEquals("external-listener", endpoint.host)
assertEquals(9999, endpoint.port)
assertEquals(SecurityProtocol.PLAINTEXT, endpoint.securityProtocol)
- assertEquals("EXTERNAL", endpoint.listenerName.value)
+ assertEquals(new ListenerName("EXTERNAL"), endpoint.listenerName)
Review comment:
You removed the `value` call from the right hand side. If you revert
that change too, then it looks fine to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
