cadonna commented on a change in pull request #8590: URL: https://github.com/apache/kafka/pull/8590#discussion_r418269289
########## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignor.java ########## @@ -34,7 +33,6 @@ import java.util.UUID; import java.util.stream.Collectors; -import static org.apache.kafka.streams.processor.internals.assignment.AssignmentUtils.taskIsCaughtUpOnClientOrNoCaughtUpClientsExist; Review comment: I removed `AssignmentUtils` and did NOT move the tests to `TaskMovementTest`. Since now `taskIsCaughtUpOnClientOrNoCaughtUpClientsExist` it is a private method, I guess it is OK. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org