bbejeck commented on pull request #8504: URL: https://github.com/apache/kafka/pull/8504#issuecomment-623500291
>Is she? I guess it's clearly document that the name is use for repartition topics, too, but it might still be an unexpected "side effect"? But I see the point that it's not too easy to resolve: Maybe we could log a warning about creating an unnecessary duplicated repartition topics (and update the docs how to resolve this, ie, via calling repartition() upfront before the join to specify one name)? Just picking one of both names seems wrong. Throwing an exception and refuse to build the topology seems too harsh? Thinking about this again, I'm now leaning towards reusing a repartition node regardless if user provides a name or not. We can update the docs to say repartition topics are only built when required and once one is created the same repartition topic is used again. WDYT? >Can you add the test for streamA-tableB, streamA-tableC join? Will do. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
