big-andy-coates commented on a change in pull request #8483:
URL: https://github.com/apache/kafka/pull/8483#discussion_r420651255
##########
File path:
streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java
##########
@@ -1643,6 +1663,8 @@ public void process(final String key, final String value)
{
new KeyValue<>("A", "recurse-alpha")
))
);
+
+ assertThat(topologyTestDriver.producedTopicNames(),
hasItem("globule-topic"));
Review comment:
You're right, I was being lazy ;)
Fixed the Globule thing.
Tried pulling the global topic out, but couldn't get the global table to
produce to to a changelog topic. I'm assuming / guess this is because there
isn't one, i.e. the source topic is the global topics changelog.
If I'm missing something, maybe you can provide an example test that would
capture the global table's change log, or maybe that can be picked up later by
someone with more experience of this code
##########
File path:
streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java
##########
@@ -450,6 +452,24 @@ public void shouldThrowForUnknownTopicDeprecated() {
}
}
+ @Test
+ public void shouldGetSinkTopicNames() {
+ testDriver = new TopologyTestDriver(setupSourceSinkTopology(), config);
+
+ pipeRecord(SOURCE_TOPIC_1, testRecord1);
+
+ assertThat(testDriver.producedTopicNames(), hasItem(SINK_TOPIC_1));
+ }
+
+ @Test
+ public void shouldGetInternalTopicNames() {
+ testDriver = new
TopologyTestDriver(setupTopologyWithTwoSubtopologies(), config);
Review comment:
done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
