C0urante commented on a change in pull request #8069:
URL: https://github.com/apache/kafka/pull/8069#discussion_r420931273



##########
File path: 
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java
##########
@@ -266,31 +422,51 @@ public void close() {
         @Override
         public void onStartup(String connector) {
             state = AbstractStatus.State.RUNNING;
-            delegate.onStartup(connector);
+            synchronized (this) {

Review comment:
       AFAICT the underlying `KafkaBasedLog` used for the status store does 
provide ordering guarantees: 
https://github.com/apache/kafka/blob/1d438033f7f4d7cbdac34e1b57d97b5a647ae4de/connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java#L242-L249




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to