hachikuji commented on a change in pull request #8602:
URL: https://github.com/apache/kafka/pull/8602#discussion_r420948852
##########
File path:
core/src/test/scala/integration/kafka/api/TransactionsBounceTest.scala
##########
@@ -156,17 +152,26 @@ class TransactionsBounceTest extends
KafkaServerTestHarness {
val expectedValues = (0 until numInputRecords).toSet
assertEquals(s"Missing messages: ${expectedValues -- recordSet}",
expectedValues, recordSet)
+ }
- verifyingConsumer.close()
+ private def createTransactionalProducer(transactionalId: String) = {
+ val props = new Properties()
+ props.put(ProducerConfig.ACKS_CONFIG, "all")
+ props.put(ProducerConfig.BATCH_SIZE_CONFIG, "512")
+ props.put(ProducerConfig.TRANSACTIONAL_ID_CONFIG, transactionalId)
+ props.put(ProducerConfig.ENABLE_IDEMPOTENCE_CONFIG, "true")
+ createProducer(configOverrides = props)
Review comment:
Nice catch. Yeah, let me fix that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
