scott-hendricks commented on pull request #8434: URL: https://github.com/apache/kafka/pull/8434#issuecomment-625306041
@ijuma Without getting too much into our testing details, our test harness takes a desired throughput and partitions it up among the Trogdor nodes as ProduceBenchSpecs. Our messagesPerSecond parameter is calculated. Our calculation is Math.Ceiling(ThroughputBps / (Trogdor Nodes * (MessageSize + KeySize))) If the end value we need is -1 we have to rework all our equations or the test harness itself to get exactly -1. If we use 0, we can still use the same harness and just specify a throughput of 0. This change would make any non-positive number run unbounded. -1 would still work as unbounded. Non-positive numbers are already invalid inputs for these functions, which is why I had hoped 0 would be acceptable. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
