cmccabe commented on a change in pull request #8628:
URL: https://github.com/apache/kafka/pull/8628#discussion_r421858418
##########
File path: core/src/main/scala/kafka/admin/ConfigCommand.scala
##########
@@ -362,21 +362,22 @@ object ConfigCommand extends Config {
).asJavaCollection
adminClient.incrementalAlterConfigs(Map(configResource ->
alterLogLevelEntries).asJava, alterOptions).all().get(60, TimeUnit.SECONDS)
- case ConfigType.User =>
- case ConfigType.Client =>
- val oldConfig: Map[String, java.lang.Double] =
getClientQuotasConfig(adminClient, entityTypes, entityNames)
+ case ConfigType.User | ConfigType.Client =>
+ val oldConfig = getClientQuotasConfig(adminClient, entityTypes,
entityNames)
val invalidConfigs = configsToBeDeleted.filterNot(oldConfig.contains)
if (invalidConfigs.nonEmpty)
Review comment:
It's not really that they're invalid, it's that we want to delete them
and they're not present, right? I realize this is an existing issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
