vvcephei commented on a change in pull request #8632:
URL: https://github.com/apache/kafka/pull/8632#discussion_r422329885



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##########
@@ -732,15 +732,16 @@ Task taskForInputPartition(final TopicPartition 
partition) {
         return tasks.values().stream().filter(t -> !t.isActive());
     }
 
+    // For testing only.
+    int commitAll() {
+        return commit(tasks.values());
+    }
+

Review comment:
       FWIW, I'd rather just inline it and avoid maintaining APIs that are just 
for tests in our production code.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to