joel-hamill commented on pull request #8222: URL: https://github.com/apache/kafka/pull/8222#issuecomment-626022261
this looks very cool. should we leave out the `=` from the rendered output? i assume it's shorthand for "equals", but i could see a reader being confused thinking it is something else. e.g. ``` 540000 (9 minutes) ``` also, if we're spelling out "minutes", should we also just go ahead and spell out the units of measure to avoid confusion as well? e.g. ``` 1073741824 (1 gibibyte) ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
