ableegoldman commented on a change in pull request #8622:
URL: https://github.com/apache/kafka/pull/8622#discussion_r427009991
##########
File path: docs/streams/upgrade-guide.html
##########
@@ -35,7 +35,7 @@ <h1>Upgrade Guide and API Changes</h1>
<p>
Upgrading from any older version to {{fullDotVersion}} is possible:
you will need to do two rolling bounces, where during the first rolling bounce
phase you set the config <code>upgrade.from="older version"</code>
- (possible values are <code>"0.10.0" - "2.4"</code>) and during the
second you remove it. This is required to safely upgrade to the new cooperative
rebalancing protocol of the embedded consumer. Note that you will remain using
the old eager
+ (possible values are <code>"0.10.0" - "2.3"</code>) and during the
second you remove it. This is required to safely upgrade to the new cooperative
rebalancing protocol of the embedded consumer. Note that you will remain using
the old eager
Review comment:
@showuon Can we clarify that you only need to do this if you're
upgrading from 2.3 or below? I know this seems implied by the fact that the
config's possible values stop at 2.3 but there are always creative
interpretations of seemingly obvious thing 🙂
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
