jiameixie commented on pull request #8692: URL: https://github.com/apache/kafka/pull/8692#issuecomment-630661883
> Wouldn't it be better to change the `[[` to `[` and thus allow use of the script in environments which aren't using `bash`? Yeah, running with below statement can also avoid error. But there are also a lot of shell scripts under directory bin which use #!/bin/bash. And sh is symlink and not a sure thing. Sometime it's bash, sometime it's dash. So I think setting all scripts use the same shell interpreter bash is better. ` if [ $(uname -s) = "OS/390" ] ` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org