feyman2016 edited a comment on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-630714942
@abbccdda I'm fixing the style error, and I found that it showed success if I run the below cmd locally : ` ./gradlew checkstyleMain checkstyleTest spotbugsMain spotbugsTest spotbugsScoverage compileTestJava ` I'm didn't find the reason after some investigating, but the style check cmdline can capture style error if I cherry-pick the first commit of this PR to another branch, guessing that it might be the second commit: `merge trunk` somehow made the style check doesn't work... So would it break our convention if I revert to the first commit:`Add option to force delete active members in StreamsResetter` and fix style error from there ? This may change the commit history of this PR. I'm asking because I noticed :"Please address feedback via additional commits instead of amending existing commits." on https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes#ContributingCodeChanges-PullRequest Thanks! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
