showuon commented on a change in pull request #8712:
URL: https://github.com/apache/kafka/pull/8712#discussion_r429289380
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java
##########
@@ -247,11 +261,19 @@ public InternalTopicManager(final Admin adminClient,
final StreamsConfig streams
log.error(errorMsg);
throw new StreamsException(errorMsg);
}
- } else {
+ } else if (!needRetryTopics.contains(topicName)) {
topicsToCreate.add(topicName);
}
}
return topicsToCreate;
}
+
+ private boolean isNeedRetry(final Set<String> topicsNotReady) {
+ return !topicsNotReady.isEmpty() || hasNeedRetryTopic();
Review comment:
If there's topic with `LeaderNotAvailableException`, we also need to
retry.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
